[dgplug-users] [Fedora offline repo] @Ratnadeep Debnath

[Shakthi Kannan]

Hi,

@rtnpro:
On commit 2737055...

* You don't have an extra newline between successive global variables.
If the global variables are related, for example, all DIR_ global
variables, then you don't need to separate them. Otherwise, give a
newline so it is easy to read.

* Give an extra newline to separate different targets. The following
is difficult to read, IMO:

=== SNIPPET ===

rpmfusion_free_updates: check_vsftpd
        mkdir -p $(FTP_DIR)/$(DIR_RPMFUSION_FREE_UPDATES); \
        $(RSYNC) $(RSYNC_FLAGS) $(SRC)/$(DIR_RPMFUSION_FREE_UPDATES) \
                $(FTP_DIR)/$(DIR_RPMFUSION_FREE_UPDATES)
rpmfusion_nonfree_releases: check_vsftpd
        mkdir -p $(FTP_DIR)/$(DIR_RPMFUSION_NONFREE_RELEASES); \
        $(RSYNC) $(RSYNC_FLAGS) $(SRC)/$(DIR_RPMFUSION_NONFREE_RELEASES) \
                $(FTP_DIR)/$(DIR_RPMFUSION_NONFREE_RELEASES)
rpmfusion_nonfree_updates: check_vsftpd
        mkdir -p $(FTP_DIR)/$(DIR_RPMFUSION_NONFREE_UPDATES);
        $(RSYNC) $(RSYNC_FLAGS) $(SRC)/$(DIR_RPMFUSION_NONFREE_UPDATES) \
                $(FTP_DIR)/$(RPMFUSION_NONFREE_UPDATES)

=== END ===

* Create a target calld "make_dirs" for example, and include targets
for creating each one of the directories. Move 'rsync' operation to a
separate target.

* Write some comments. Comments start with #.

* Give a space after "all:".

* Instead of just using "echo $$value", try to use ASCII art with
cowsay or banner or figlet (licensing not fixed yet, but, available
from rpmforge) with a meaningful message. Don't directly call the
commands in the Makefile. Get the output and use echo in the Makefile
to display the output.

After these commit changes, send a merge request.

SK

-- 
Shakthi Kannan
http://www.shakthimaan.com